Re: opendkim 2.5.1 crash

From: Дилян Палаузов <dilyan.palauzov_at_aegee.org>
Date: Thu, 05 Apr 2012 21:04:36 +0200

Hello,

ops, I have taken opendkim/opendkim.c from somewhere else (probably
commit a042e6abf6feb73e73), changing compared to
opendkim-2.5.1/opendkim/opendkim.c

13458c13453,13454
< if (dkimf_local_adsp(conf, (char *) domain,

---
>                               if (domain != NULL &&
>                                   dkimf_local_adsp(conf, (char *) domain,
and 5 empty newlines.
By the way, another question, about Authentication-Results:
When a message is submitted from the MUA to the MSA over authenticated 
SMTP-Session, the MSA can add a Authentication-Results: header, 
indicating that auth=pass (method) smtp.auth=username, whereas opendkim 
can add to the same message, Authentication-Results: dkim=pass, when the 
MUA has signed itself the message.  Wouldn't it be wise, if opendkim 
considers near the DKIM-Signature during the verification, also the 
{auth_type} and {auth_authen} macros, and amends Authentication-Results: 
with the SMTP-authentication results (if any).
Със здраве
   Дилян
On 05.04.2012 20:33, Todd Lyons wrote:
> 2012/4/5 Murray S. Kucherawy<msk_at_blackops.org>:
>>> #3  0x00007f34636eaa02 in __GI___assert_fail (
>>>    assertion=assertion_at_entry=0x44aca6 "sig != ((void *)0)",
>>>    file=file_at_entry=0x4498d7 "opendkim.c", line=line_at_entry=14092,
>>>    function=function_at_entry=0x44e8ea "mlfi_eom") at assert.c:103
>>> #4  0x000000000041a3bc in mlfi_eom (ctx=0x20c3370) at opendkim.c:14092
>>
>>
>> Line 14092 in the 2.5.1 release was not an assertion check line.  Are you
>> running with some patches to the source?
>
> I think it's this code segment, line 14097 in current develop HEAD:
>
>                      else if (dfc->mctx_status == DKIMF_STATUS_VERIFYERR)
>                      {
>                          int errcode;
>                          const char *err;
>                          DKIM_SIGINFO *sig;
>
>                          authresult = "permerror";
>
>                          sig = dkim_getsignature(dfc->mctx_dkimv);
>                          assert(sig != NULL);
>
>
> ...Todd

Received on Thu Apr 05 2012 - 19:04:53 PST