Re: v2.2.2 prerelease available

From: Hirohisa Yamaguchi <umq.461_at_gmail.com>
Date: Thu, 18 Nov 2010 21:08:32 +0900

On Thu, Nov 18, 2010 at 3:18 AM, Murray S. Kucherawy <msk_at_cloudmark.com> wrote:
>> opendkim-dns.c:612:22: warning: passing 'unsigned char *' to parameter
>> of type 'char *' converts between pointers to integer types with
>> different sign [-Wpointer-sign]
>>         q = ar_addquery(ar, query, C_IN, type, MAXCNAMEDEPTH, buf,
>> buflen,
>>                             ^~~~~
>> In file included from opendkim-dns.c:34:
>> ./../libar/ar.h:58:43: note: passing argument to parameter here extern
>> AR_QUERY ar_addquery(AR_LIB, char *, int, int, int, unsigned char *,
>>                                           ^
>> 1 warning generated.
>
> Fixed that one.  A build on Solaris 10, which complains about these, didn't whine about any others apart from an array of strings in dkim.c defined as u_char ** but is initialized with string literals, which are char *. I could cast each string to u_char * but I'm fine with ignoring those.
>
> If you got other warnings, please let me know.

there's a similar one in dkim-dns.c.
patch attached.


Regards,
-- 
	Hirohisa Yamaguchi
	  <umq.461_at_gmail.com>



Received on Fri Nov 19 2010 - 15:46:48 PST

This archive was generated by hypermail 2.3.0 : Mon Oct 29 2012 - 23:32:54 PST