RE: v2.2.2 prerelease available

From: Murray S. Kucherawy <msk_at_cloudmark.com>
Date: Wed, 17 Nov 2010 10:18:41 -0800

> -----Original Message-----
> From: Hirohisa Yamaguchi [mailto:umq.461_at_gmail.com]
> Sent: Wednesday, November 17, 2010 1:11 AM
> To: Murray S. Kucherawy
> Cc: opendkim-dev_at_lists.opendkim.org
> Subject: Re: v2.2.2 prerelease available
>
> Hi,
>
> On Wed, Nov 17, 2010 at 7:58 AM, Murray S. Kucherawy
> <msk_at_cloudmark.com> wrote:
> > I've cleaned these up now. I had neglected to try a build with
> DomainKeys enabled. Sorry about that.
> >
> > The tarball at the previous URL has now been replaced.
>
> I got some warnings under environment following:
>
> $ TZ=UTC ls -Tl /usr/ports/distfiles/opendkim-2.2.2.tar.gz
> -rw-r--r-- 1 root wheel 1097059 Nov 17 00:42:45 2010
> /usr/ports/distfiles/opendkim-2.2.2.tar.gz
> $ uname -v
> FreeBSD 7.1-RELEASE-p15 #0: Wed Nov 10 10:51:13 UTC 2010 root_at_amd64-
> builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC
> $ clang -v
> clang version 2.9 (trunk)
> Target: x86_64-portbld-freebsd7.1
> Thread model: posix
>
> # clang/LLVM might be going to be the default compiler of FreeBSD.
>
> Extracting the warnings, instead of attaching whole build log.
> --
> clang -DHAVE_CONFIG_H -I. -I.. -I./../libopendkim -
> I/usr/local/include
> -I/usr/include -D_THREAD_SAFE -pthread -I./../libar -O2
> -fno-strict-aliasing -pipe -MT opendkim-opendkim.o -MD -MP -MF
> .deps/opendkim-opendkim.Tpo -c -o opendkim-opendkim.o `test -f
> 'opendkim.c' || echo './'`opendkim.c
> opendkim.c:10735:22: warning: result of comparison against a string
> literal is unspecified (use strncmp instead)
> if (dfc->mctx_jobid == (u_char *) JOBIDUNKNOWN)
> ^ ~~~~~~~~~~~~~~~~~~~~~~~
> 1 warning generated.

Fixed.

> --
>
> and numerous pointer sign warnings(i.e. (unsigned char *) vs (char *).
> such as:
> --
> clang -DHAVE_CONFIG_H -I. -I.. -I./../libopendkim -
> I/usr/local/include
> -I/usr/include -D_THREAD_SAFE -pthread -I./../libar -O2
> -fno-strict-aliasing -pipe -MT opendkim-opendkim-dns.o -MD -MP -MF
> .deps/opendkim-opendkim-dns.Tpo -c -o opendkim-opendkim-dns.o `test -f
> 'opendkim-dns.c' || echo './'`opendkim-dns.c
> opendkim-dns.c:612:22: warning: passing 'unsigned char *' to parameter
> of type 'char *' converts between pointers to integer types with
> different sign [-Wpointer-sign]
> q = ar_addquery(ar, query, C_IN, type, MAXCNAMEDEPTH, buf,
> buflen,
> ^~~~~
> In file included from opendkim-dns.c:34:
> ./../libar/ar.h:58:43: note: passing argument to parameter here extern
> AR_QUERY ar_addquery(AR_LIB, char *, int, int, int, unsigned char *,
> ^
> 1 warning generated.

Fixed that one. A build on Solaris 10, which complains about these, didn't whine about any others apart from an array of strings in dkim.c defined as u_char ** but is initialized with string literals, which are char *. I could cast each string to u_char * but I'm fine with ignoring those.

If you got other warnings, please let me know.

The posted tarball has been replaced.

-MSK
Received on Wed Nov 17 2010 - 18:18:51 PST