Re: OpenDKIM v2.7.2 released

From: Murray S. Kucherawy <msk_at_blackops.org>
Date: Wed, 21 Nov 2012 06:59:35 -0800 (PST)

On Wed, 21 Nov 2012, Eray Aslan wrote:
> warnings during build with commit 9d3b6fbf. These warnings are never
> good and I would like to avoid them if possible. Checking for native
> implementation first and if not found checking for strl.h and if that is
> not found as well, assuming an external strl library is not available
> and building our own seems to be a better solution.

Under those conditions, there's quite possibly a libstrl already installed
without a strl.h, so trying to install our own libstrl would cause a
filename collision and an install failure.

> In other words, our options seem to be, in no particular order
> - rename internal libstrl library

I'm not too keen on peppering people's installations with a variety of
strlcat/strlcpy implementations. We probably shouldn't do this.

> - provide strl.h along with the libstrl library

By that you mean install strl.h if there isn't one, even if you're not
installing the library?

> - include strl in LIBS only if strl.h is found

Wouldn't that cause runtime failures or build failures, since that would
mean those functions go unresolved?

A fourth option would be to force our libstrl to be static, always link
against that, and never install it.

A fifth option would be to provide documentation that we got 2.7.1 wrong
by not installing strl.h, and have people manually remove our libstrl from
those installations before doing "make install" for 2.7.2 or later, if
they want those warnings to go away.

-MSK
Received on Wed Nov 21 2012 - 14:59:53 PST