dkim_set_signer() - sign inconsistency

From: Nigel Horne <njh_at_bandsman.co.uk>
Date: Fri, 15 Apr 2011 18:10:51 -0400

The documentation for dkim_set_signer at http://www.opendkim.org/libopendkim/dkim_set_signer.html says that the second argument is 'const char *, however dkim.h has it listed as 'const u_char *'.

The same inconsistency happens in dkim_get_signer.

While we're at it, I'm surprised that you pass a const into dkim_set_signer, but the return value for dkim_set_signer isn't marked as a constant, so a caller's code could mistakenly tranch all over it without the compiler warning.

Regards,

-Nigel


Received on Fri Apr 15 2011 - 22:11:18 PST

This archive was generated by hypermail 2.3.0 : Mon Oct 29 2012 - 23:20:17 PST