RE: dkim_set_signer() - sign inconsistency

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]

From: Murray S. Kucherawy <msk_at_cloudmark.com>
Date: Fri, 15 Apr 2011 15:17:04 -0700

> -----Original Message-----
> From: opendkim-users-bounce_at_lists.opendkim.org [mailto:opendkim-users-bounce_at_lists.opendkim.org] On Behalf Of Nigel Horne
> Sent: Friday, April 15, 2011 3:11 PM
> To: opendkim-users_at_lists.opendkim.org
> Subject: dkim_set_signer() - sign inconsistency
>
> The documentation for dkim_set_signer at
> http://www.opendkim.org/libopendkim/dkim_set_signer.html says that the
> second argument is 'const char *, however dkim.h has it listed as
> 'const u_char *'.
>
> The same inconsistency happens in dkim_get_signer.
>
> While we're at it, I'm surprised that you pass a const into
> dkim_set_signer, but the return value for dkim_set_signer isn't marked
> as a constant, so a caller's code could mistakenly tranch all over it
> without the compiler warning.

All fixed.
Received on Fri Apr 15 2011 - 22:17:16 PST