You forgot the patch. Is it somewhere in git?
Murray S. Kucherawy wrote:
> On Wed, 26 Sep 2012, Ken Murchison wrote:
>> Optimally, the signature would only be calculated when the application
>> calls dkim_getsighdr(). I see that its really calculated in
>> dkim_eom_sign(), which is what causes the major problem in reusing the
>> signing handle. I haven't looked at all of the logic to see why its
>> done that way, and what, if anything, would break if its pulled out of
>> there.
>
> Going back a long way, I think dkim_eom() has always generated the
> signature, and then something called dkim_getsig() or something would
> just pull it out in a printable form. It's mostly stayed that way just
> to keep the dkim_eom() call simple and aligned with the milter
> interface. Basically there just hasn't been a reason to consider
> rearranging it until now.
>
>> I can certainly fix the dkim_add_xtag() issue since its trivial. If
>> you want to direct me with some thoughts on the reusing the signing
>> handle, I would be willing to work on the code.
>
> Adding replacement logic to dkim_add_xtag() would help, yes. Thanks for
> offering. Also, try the attached patch, which allows a signing handle
> to be bound to another signing handle. The patch also updates the
> documentation.
>
> -MSK
>
--
Kenneth Murchison
Principal Systems Software Engineer
Carnegie Mellon University
Received on Thu Sep 27 2012 - 02:52:53 PST