On Fri, Aug 26, 2011 at 7:47 AM, Steve Jenkins <stevejenkins_at_gmail.com> wrote:
>> Very good point, I never noticed that. Steve, it's typical for a
>> package with an init script that requires some user customization of
>> startup parameters to:
>> 1. Create a %{sysconfdir}/sysconfig/%{name} file which will contain simply:
>> 2. And then in the init script, after you set any default options,
> Yep. That's a great idea from Daniel. After 2.4.2-3 gets pushed out of
> the testing repos to the stable ones (which should be within the week)
> I'll add that in (I don't want to commit an update to a new package
> until it's run through the entire new package process).
Understood.
>> Ah, yeah, we need to handle selinux scenarios too. I hate SELinux. :-(
> Coincidentally, I got this email two days ago:
>
> "I saw your initial self-intro on the packaging list and was going to
> reply then but I've been rather busy with various things and I never
> got round to it. I see Matt D has sponsored you already but I still
> may be able to offer some assistance: have you tried the milter with
> SELinux Enforcing?
I just installed it on my personal server which has SELinux Permissive
mode set. I'll be able to see the AVC comments and can test anything
you want.
> "I maintain in Fedora spamass-milter and milter-regex, and I also have
> local packages for smf-spf and smf-sav. I have SELinux policy for all
> of these, and wrote the milter policy in SELinux reference policy,
> which is what Fedora's SELinux policy is based on.
>
> "Please let me know if I can be of help."
DING DING, we have a WINNER! I nominate him to help us unless Dan
beats him to it.
> I'm an SELinux hater, too - I know nothing about it except how to
> disable it, which is the absolute first thing I do on a new install.
> I'll follow up with Paul to help us out with this.
I found a small bug and possibly a change that at least deserves
consideration. We have stats capability enabled by default in the
binary, but not in the config file:
1. In opendkim.conf, the statistics directive is commented out. This
is good because the defined stats directory is /var/opendkim/stats,
which does not exist because /var/opendkim is not owned by the
opendkim package. This is what /var/spool/opendkim was created for,
so the path in the config file (even though it's commented out) should
be changed to /var/spool/opendkim.
2. In the same vein, the filename "stats" could be very confusing to
someone looking at this for the first time. I ask that you consider
naming it stats.txt to clearly indicate to people that it's just a
plain text file.
3. Since we enable stats by default, we should include the script and
readme for stats:
%doc contrib/stats/README.opendkim-reportstats
install contrib/stats/opendkim-reportstats to
%{prefix}/bin/opendkim-reportstats
modify the opendkim-reportstats to use the defaults you specify in #1
and #2 above. Use either or sed or awk or whatever you can to make
that work. I can give you simple command if necessary.
...Todd
--
If Americans could eliminate sugary beverages, potatoes, white bread,
pasta, white rice and sugary snacks, we would wipe out almost all the
problems we have with weight and diabetes and other metabolic
diseases. -- Dr. Walter Willett, Harvard School of Public Health
Received on Fri Aug 26 2011 - 17:30:27 PST