Re: br-msk-stats-update

From: Alessandro Vesely <vesely_at_tana.it>
Date: Mon, 30 Aug 2010 12:28:16 +0200

On 29/Aug/10 22:27, Murray S. Kucherawy wrote:
> On Sun, 29 Aug 2010, Alessandro Vesely wrote:
>> If that <TAB> makes it to the plain stats file, strtok will choke on
>> it, and give an invalid M line.
>
> Ah, true. I've patched the code to fix this now. (Note that I don't
> really feel the need to make this completely bulletproof like I would
> canonicalization code or a MIME parser, but that was an easy fix to
> put in.)

Agreed. The code is still vulnerable to, say,

   Content-Type: text(here is the <TAB>)/plain;

but I've never seen such beasts, and can't see a reason for attacking
the stats. (It is possible to prevent a message's data from being
imported, but why would anyone want to do that?)

> While I'm at it, I've changed the "syntax" generation code to report
> the full error code and not just a Boolean. This allowed elimination
> of a few columns in the new code's "signatures" table.

Well done!
Received on Mon Aug 30 2010 - 10:28:27 PST

This archive was generated by hypermail 2.3.0 : Mon Oct 29 2012 - 23:32:53 PST