RE: Opendkim-2.1.0beta0 build failure

From: Murray S. Kucherawy <msk_at_cloudmark.com>
Date: Mon, 24 May 2010 13:52:40 -0700

> -----Original Message-----
> From: opendkim-dev-bounce_at_lists.opendkim.org [mailto:opendkim-dev-
> bounce_at_lists.opendkim.org] On Behalf Of Graham Murray
> Sent: Monday, May 24, 2010 1:40 PM
> To: opendkim-dev_at_lists.opendkim.org
> Subject: Opendkim-2.1.0beta0 build failure
>
> 1) Building 2.1.0Beta0 fails if configured with --enable-stats and --
> with-lua and/or
> --with-odbx. When --enable-stats is set, OPENDKIM_DB_ONLY is defined
> which causes USE_LDAP, USE_SASL, USE_ODBX and USE_LUA to be undefined
> which in turn means that the appropriate header files are not included.
>
> gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -DOPENDKIM_DB_ONLY -
> I./../libopendkim -I/usr/include -march=native -O2 -pipe -MT
> opendkim_stats-opendkim-db.o -MD -MP -MF .deps/opendkim_stats-opendkim-
> db.Tpo -c -o opendkim_stats-opendkim-db.o `test -f 'opendkim-db.c' ||
> echo './'`opendkim-db.c
> opendkim-db.c: In function ‘dkimf_db_get’:
> opendkim-db.c:2747: error: storage size of ‘lres’ isn’t known
> opendkim-db.c:2753: warning: implicit declaration of function
> ‘dkimf_lua_db_hook’
> make[2]: *** [opendkim_stats-opendkim-db.o] Error 1
> make[2]: Leaving directory `/home/graham/opendkim-2.1.0/opendkim'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/home/graham/opendkim-2.1.0'
> make: *** [all] Error 2

But that code is inside an #ifdef USE_LUA, so if USE_LUA has been undefined, it shouldn't try to compile that.

Turns out "util.h" includes "build-config.h" which restores those various "USE_*" macros. Oops...

Fixed for Beta1, which I'll push out Wednesday. Patch attached.

> 2) stats/README instructs using the mkdb.mysql script to create the
> mysql database table(s). This script is not in the tarball

Also fixed for the Wednesday release, and that file is attached here.

Thanks for the report!

-MSK


Received on Mon May 24 2010 - 20:53:07 PST