On Fri, Feb 26, 2010 at 11:52:15AM -0800, Murray S. Kucherawy <msk_at_cloudmark.com> wrote:
> As opposed to earlier versions of Lua? I don't know, but since beginning to look at it the only version I've encountered has been 5.1. 5.2 is coming out, but as yet I've not read of any projected incompatibilities. There are earlier versions available on the web site if you think we should try, but 5.1 is four years old now. I'd be fine establishing a minimum requirement there so I've modified configure.ac to fail on anything older than 5.1.
Didn't realize 5.1 was that old. I care much less knowing that.
> For that matter, we might want to do this with OpenLDAP too, so I've added that (minimum is 2.1.3). We already cope with older versions of OpenSSL and Sleepycat. Unfortunately OpenDBX's includes don't have any way to determine what version is installed (except when pkg-config is available), so we just have to wing it there.
It's in INSTALL, so that's as much as we can reasonably do, right?
> > Did we ever get anywhere with figuring out the minimum autotools
> > version? I'm just thinking about what docs need to be done for 2.0.0.
>
> Since the packaging process creates ./configure and all the Makefile.in files, I don't think the end users actually need to have any of autotools installed. They only need such things if they're modifying configure.ac or any of the Makefile.am files themselves; if that's the case, I think we can reasonably expect them to have current autotools anyway. But I'd be fine documenting what I'm using to build the package if you think that's good enough.
I thought Daniel was taking a swipe at that one.
> > It looks like SMFI_VERSION served this purpose in Sendmail versions
> > prior to 8.14.0, at which point it was modified to specify the version
> > of libmilter itself instead of the API. Proposed fix:
> > --- miltertest/miltertest.c 25 Feb 2010 20:07:15 -0000 1.9
> > +++ miltertest/miltertest.c 26 Feb 2010 18:28:52 -0000
> > _at_@ -89,6 +89,11 @@
> > #define MT_QUARANTINE 8
> > #define MT_SMTPREPLY 9
> >
> > +/* Versions of Sendmail prior to 8.14 don't define SMFI_PROT_VERSION.
> > Use SMFI_VERSION. */
> > +#ifndef SMFI_PROT_VERSION
> > +# define SMFI_PROT_VERSION SMFI_VERSION
> > +#endif
>
> That seems reasonable. They changed format of the version from a straight integer to a hex encoding, but a big hex number is still a lot bigger than "3" so I think it'll work. :-) I've committed it now.
Right, but that will only happen if SMFI_PROT_VERSION isn't available in
the headers already, in which case the number shouldn't be any higher
than 2 (SMFI_VERSION from 8.13.8), since SMFI_PROT_VERSION should be
defined from 8.14.0 on. Not disagreeing, just suggesting that miltertest
should never see the big hex number in that macro :).
> I'll ping someone over there for some help, but I'm not concerned enough about it to delay the release.
For a test tool? Sounds totally reasonable to me.
--
Mike Markley <mike_at_markley.org>
One Bell System - it sometimes works.
Received on Fri Feb 26 2010 - 20:15:23 PST