Misc bits for 2.0.0

From: Mike Markley <mike_at_markley.org>
Date: Fri, 26 Feb 2010 10:33:13 -0800

Does the OpenDKIM code depend on features available only in Lua 5.1?

Did we ever get anywhere with figuring out the minimum autotools
version? I'm just thinking about what docs need to be done for 2.0.0.

I also realized that I completely forgot to bring up one miltertest
build issue I have:
miltertest.c: In function 'mt_assert_state':
miltertest.c:490: error: 'SMFI_PROT_VERSION' undeclared (first use in this function)
miltertest.c:490: error: (Each undeclared identifier is reported only once
miltertest.c:490: error: for each function it appears in.)
miltertest.c: In function 'mt_negotiate':
miltertest.c:1263: error: 'SMFI_PROT_VERSION' undeclared (first use in this function)

It looks like SMFI_VERSION served this purpose in Sendmail versions
prior to 8.14.0, at which point it was modified to specify the version
of libmilter itself instead of the API. Proposed fix:
--- miltertest/miltertest.c 25 Feb 2010 20:07:15 -0000 1.9
+++ miltertest/miltertest.c 26 Feb 2010 18:28:52 -0000
_at_@ -89,6 +89,11 @@
 #define MT_QUARANTINE 8
 #define MT_SMTPREPLY 9

+/* Versions of Sendmail prior to 8.14 don't define SMFI_PROT_VERSION. Use SMFI_VERSION. */
+#ifndef SMFI_PROT_VERSION
+# define SMFI_PROT_VERSION SMFI_VERSION
+#endif
+
 /* prototypes */
 int mt_abort(lua_State *);
 int mt_bodyfile(lua_State *);
_at_@ -172,6 +177,130 @@

Thoughts? Does miltertest even support such an old version of the Milter
API?

-- 
Mike Markley <mike_at_markley.org>
Received on Fri Feb 26 2010 - 18:33:21 PST

This archive was generated by hypermail 2.3.0 : Mon Oct 29 2012 - 23:32:52 PST