Re: Review request: br-msk-lua, br-msk-libprofiling

From: SM <sm_at_resistor.net>
Date: Tue, 22 Dec 2009 17:17:30 -0800

Hi Murray,
At 16:34 22-12-2009, Murray S. Kucherawy wrote:
>These are ready to merge to the trunk, but I need a reviewer before
>I can proceed.
>
>br-msk-libopendkim contains some performance improvements to
>libopendkim that I found while experimenting with Daniel's code
>coverage and profiling work. The changes cut out a huge number of
>calls to strlen() and make a few other minor optimizations. "make
>check" on the library still passes all tests. This will be a pretty
>short review.

I'll do the review. Even though it is short, I don't think I would
be able to do it over the next few days.

>I'm really keen to merge br-msk-lua before starting down the road of
>reworking the data structures around the previously-discussed
>scalability feature issues, so that one should take priority if
>possible. Doing them in the opposite order will make the merge a
>great deal more difficult. Unfortunately there's quite a bit to go
>over in there.

I want to look at that next as it opens new avenues.

Regards,
-sm
Received on Wed Dec 23 2009 - 01:18:19 PST